[PATCH] D19838: [LLVM-AR] Fixed bug where temporary file would be left behind every time an archive was updated

[Rafael Ávila de Espíndola via llvm-commits]

rafael added a subscriber: rafael.

================
Comment at: include/llvm/Object/Archive.h:179
@@ +178,3 @@
+  // We supply two flavours of constructors, one that can work with an existing
+  // buffer, and another that takes over ownership of a buffer. It is sometimes
+  // important to link ownership of the buffer with the archive in the case where
----------------
We really should not do this.

All these objects just wrap a MemoryBufferRef.  It is llvm-ar that should be deleting these buffers earlier.


Repository:
  rL LLVM

http://reviews.llvm.org/D19838