[lld] r268345 - Temporarily disable this test on llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast

[Rafael Espíndola via llvm-commits]

My patch fixed the issue, but I agree with Paul. It is useful to know
that there was an issue.

We should not change the name of the bot.

Cheers,
Rafael


On 3 May 2016 at 15:15, Sean Silva via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
>
> On Tue, May 3, 2016 at 9:34 AM, Robinson, Paul <paul.robinson at sony.com>
> wrote:
>>
>>
>>
>> > -----Original Message-----
>> > From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On
>> > Behalf
>> > Of Sean Silva via llvm-commits
>> > Sent: Monday, May 02, 2016 5:36 PM
>> > To: llvm-commits at lists.llvm.org
>> > Subject: [lld] r268345 - Temporarily disable this test on
>> > llvm-clang-lld-
>> > x86_64-scei-ps4-windows10pro-fast
>> >
>> > Author: silvas
>> > Date: Mon May  2 19:36:15 2016
>> > New Revision: 268345
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=268345&view=rev
>> > Log:
>> > Temporarily disable this test on llvm-clang-lld-x86_64-scei-ps4-
>> > windows10pro-fast
>> >
>> > `REQUIRES: shell` is not appropriate because that would mean that there
>> > are no windows bots testing this, and that is precisely where it needs
>> > the most testing.
>> >
>> > Rafael or Rui are working on generating an archive directly, which
>> > should avoid this issue.
>> > We can try to move the bot to a shorter build directory path.
>>
>> If you "fix" the bot to use short paths, we'll never find these things...
>> The short/long path thing is just a fact of life on Windows and we do
>> need to tolerate it.
>
>
> I tend to agree. Hopefully Rafael's archive patch will actually solve the
> issue.
>
> There is a bit of a slippery slope though, as every test needs *some* amount
> of file path length slack. The question is how much is reasonable.
> For example, we could put the build dir at a path of length `PATH_MAX - 1`.
> Obviously then we won't be able to even create `$BUILDDIR/lib/` or whatnot.
> Ultimately we might settle at `PATH_MAX - 42` which is enough for the build
> (`42` is just for the sake of choosing a number; I don't know the actual
> number). So then does this mean that our tests basically assume that we have
> 42 characters of slack on customer machines?
>
> I'm not sure what the right tradeoff is. In the case of a test like this
> that essentially "doubles" the number of characters in a path, it is
> probably clear that we need to be careful about it. But what about a test
> that needs 43 extra characters? 47 extra characters? 127 extra characters?
>
> Thoughts?
>
> -- Sean Silva
>
>
>>
>> --paulr
>>
>> >
>> > Modified:
>> >     lld/trunk/test/ELF/reproduce.s
>> >
>> > Modified: lld/trunk/test/ELF/reproduce.s
>> > URL: http://llvm.org/viewvc/llvm-
>> >
>> > project/lld/trunk/test/ELF/reproduce.s?rev=268345&r1=268344&r2=268345&view
>> > =diff
>> >
>> > ==========================================================================
>> > ====
>> > --- lld/trunk/test/ELF/reproduce.s (original)
>> > +++ lld/trunk/test/ELF/reproduce.s Mon May  2 19:36:15 2016
>> > @@ -1,5 +1,10 @@
>> >  # REQUIRES: x86
>> >
>> > +# XXX: Temporary hack to work around windows path length limitation due
>> > to
>> > +# the build dir for llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast.
>> > +# When we directly generate an archive this won't be an issue.
>> > +# XFAIL: x86_64-scei-ps4
>> > +
>> >  # RUN: rm -rf %t.dir
>> >  # RUN: mkdir -p %t.dir/build1
>> >  # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o
>> > %t.dir/build1/foo.o
>> >
>> >
>> > _______________________________________________
>> > llvm-commits mailing list
>> > llvm-commits at lists.llvm.org
>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>