[PATCH] D19875: [sanitizer] Move stat/__xstat to the common interceptors

[Qin Zhao via llvm-commits]

zhaoqin added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_platform_interceptors.h:300
@@ -293,1 +299,3 @@
+#define SANITIZER_INTERCEPT_STAT SI_FREEBSD || SI_MAC || SI_ANDROID
+#define SANITIZER_INTERCEPT___XSTAT !SI_FREEBSD
 #endif  // #ifndef SANITIZER_PLATFORM_INTERCEPTORS_H
----------------
aizatsky wrote:
> It looks like both stat & xstat will be intercepted on mac & android.
> 
> Should this be !SANITIZER_INTERCEPT_STAT? 
If so, I am not sure if we need SANITIZER_INTERCEPT___XSTAT.
I thought SANITIZER_INTERCEPT___XSTAT is !SANITIZER_INTERCEPT_STAT, but Evgeniy suggested to add SANITIZER_INTERCEPT___XSTAT separately.
Evgeniy could you please comment on this?


Repository:
  rL LLVM

http://reviews.llvm.org/D19875