[PATCH] D19872: Produce cpio files for --reproduce

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue May 3 09:17:50 PDT 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.

Thank you for doing this. This should be much more reliable than moving files on the actual file system.


================
Comment at: ELF/Driver.cpp:267
@@ -261,3 +266,3 @@
     return;
 
   switch (Config->EKind) {
----------------
You can move maybeCloseReproArchive here because all input files (referred directly or indirectly) should be read until this point.

================
Comment at: ELF/Driver.cpp:494
@@ -488,1 +493,3 @@
 
+  maybeCloseReproArchive();
+
----------------
Remove.


http://reviews.llvm.org/D19872





More information about the llvm-commits mailing list