[PATCH] D19813: Move "Eliminate Available Externally" immediately after the inliner

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Tue May 3 08:40:45 PDT 2016


tejohnson added a comment.

LGTM


================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:410
@@ +409,3 @@
+    // Remove avail extern fns and globals definitions if we aren't
+    // compiling an object file for later LTO. For LTO we want to preserve
+    // these so they are eligible for inlining at link-time. Note if they
----------------
Ah, I had forgotten that PrepareForLTO included all -flto settings. Now that we have PrepareForThinLTO I like the idea of separating them. Probably should then change PrepareForLTO to PrepareForFullLTO to disambiguate (not here, but as a separate cleanup).


http://reviews.llvm.org/D19813





More information about the llvm-commits mailing list