[PATCH] D19792: AMDGPU/R600: Implement loads from constant AS
Tom Stellard via llvm-commits
llvm-commits at lists.llvm.org
Tue May 3 08:25:22 PDT 2016
tstellarAMD added inline comments.
================
Comment at: lib/Target/AMDGPU/R600ISelLowering.cpp:1070
@@ -1092,3 +1069,3 @@
SDValue R600TargetLowering::LowerImplicitParameter(SelectionDAG &DAG, EVT VT,
SDLoc DL,
----------------
You are correct about the wrapper, but what I'm saying is why even emit a GlobalAddress at all. Why not do return DAG.getConstant(0, MVT::i32), like we do when lowering LDS global addresses.
Repository:
rL LLVM
http://reviews.llvm.org/D19792
More information about the llvm-commits
mailing list