[PATCH] D19716: [mips] Use MipsMCExpr instead of MCSymbolRefExpr for all relocations.

[Simon Dardis via llvm-commits]

sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM with the two nits (spelling/control flow) addressed.


================
Comment at: lib/Target/Mips/MCTargetDesc/MipsMCExpr.h:85-86
@@ +84,4 @@
+  bool isGpOff() const {
+    MipsExprKind Kind;
+    return isGpOff(Kind);
+  }
----------------
dsanders wrote:
> sdardis wrote:
> > Should this be 'return isGpOff(Kind);' as the local declaration of 'Kind' here shadows the class definition.
> This is intended to discard the MipsExprKind result from the other isGpOff predicate. I can call it 'Unused' if that's preferable.
No, that's fine as is.


http://reviews.llvm.org/D19716