[PATCH] D19782: [IPO/GlobalDCE] Port to the new PM.

[Davide Italiano via llvm-commits]

On Mon, May 2, 2016 at 9:13 PM, Justin Bogner via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Davide Italiano <dccitaliano at gmail.com> writes:
>> davide added inline comments.
>>
>> ================
>> Comment at: lib/LTO/LTOCodeGenerator.cpp:107
>> @@ -106,3 +106,3 @@
>>    initializePruneEHPass(R);
>> -  initializeGlobalDCEPass(R);
>> +  initializeGlobalOptLegacyPassPass(R);
>>    initializeArgPromotionPass(R);
>> ----------------
>> mcrosier wrote:
>>> GlobalDCELegacyPassPass?
>> Just followed what was already there. See, for example
>> InstructionCombining or GlobalOPT.
>
> I think Chad's trying to say that there's a typo here, and you wrote
> "Opt" instead of "DCE". Not really sure how that doesn't break anything
> though... :/
> _______________________________________________


I apologize, I completely overlooked :| Weird it wasn't caught by the
test suite.
BTW, I'll make sure I'll fix before committing (and also try to find a
way to catch these in the future).

Thank you all for reviewing!

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare