[PATCH] D19790: AMDGPU: Add support for MCExpr to instruction printer

[Jan Vesely via llvm-commits]

jvesely added inline comments.

================
Comment at: lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.cpp:608-609
@@ +607,4 @@
+  if (Op.isImm()) {
+    int64_t Imm = Op.getImm();
+    O << Imm << '(' << BitsToFloat(Imm) << ')';
+  }
----------------
arsenm wrote:
> Why change this? It's already being truncated. Maybe add an explicit static_cast to the Imm assignment?
Since there should be only 32 bit values, the idea was to print all 64 bits and catch any bugs/corruption in asm output.


Repository:
  rL LLVM

http://reviews.llvm.org/D19790