[PATCH] D19840: Parse and dump PDB TPI Stream

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: include/llvm/DebugInfo/PDB/Raw/TpiStream.h:22
@@ +21,3 @@
+
+typedef uint32_t(__fastcall *HashFunctionType)(uint8_t *, uint32_t);
+
----------------
Why do you need __fastcall here?

================
Comment at: lib/DebugInfo/PDB/Raw/ByteStream.cpp:66
@@ +65,3 @@
+    return std::make_error_code(std::errc::bad_address);
+  Buffer = ArrayRef<uint8_t>(Data.data() + Offset, Length);
+  return std::error_code();
----------------
I think you can use ArrayRef::slice.


http://reviews.llvm.org/D19840