[PATCH] D19824: [codeview] Isolate type dumping from object file state

Adrian McCarthy via llvm-commits llvm-commits at lists.llvm.org
Mon May 2 13:46:32 PDT 2016


amccarth added inline comments.

================
Comment at: tools/llvm-readobj/COFFDumper.cpp:57
@@ +56,3 @@
+public:
+  CVTypeDumper(StreamWriter &W) : W(W) {}
+
----------------
explicit?

================
Comment at: tools/llvm-readobj/COFFDumper.cpp:70
@@ +69,3 @@
+
+  /// All user defined type records in .debug$T live in here. Type indices
+  /// greater than 0x1000 are user defined. Subtract 0x1000 from the index to
----------------
user-defined (hyphen)


Repository:
  rL LLVM

http://reviews.llvm.org/D19824





More information about the llvm-commits mailing list