[PATCH] D18541: [CodeGen] Consider register modified if it's used to pass landing pad parameters.

Marcin Koƛcielnicki via llvm-commits llvm-commits at lists.llvm.org
Mon May 2 13:09:59 PDT 2016


koriakin added a comment.

In http://reviews.llvm.org/D18541#418973, @MatzeB wrote:

> I think you should rather change the TargetFrameLowering::determineCalleeSaves() callback of the target to mark the registers as callee saved.
>
> If this really makes sense for all targets then it could also be done in the PrologEpilogueInsertion code before/after determineCalleeSaves(), but I am not convinced yet this applies universally (though I'm no expert in exception handling code).


Well, this applies to any target whose exception pointer/selector registers are callee-save.  I'm not sure if there's any target other than SystemZ where that applies for the default calling convention.  However, it can apply to other targets as well if you have a landing pad in a function with eg. preserve_mostcc calling convention - is that supposed to work?


Repository:
  rL LLVM

http://reviews.llvm.org/D18541





More information about the llvm-commits mailing list