[PATCH] D18831: [Coverage] Combine counts of expansion region if there are no code regions for the same area.
David Li via llvm-commits
llvm-commits at lists.llvm.org
Mon May 2 11:02:11 PDT 2016
davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.
other than vsk's comments, lgtm.
================
Comment at: lib/ProfileData/CoverageMapping.cpp:378
@@ +377,3 @@
+ // to accumulate counts only from CodeRegions, or else the area will be
+ // counted twice. On the other hand, the area might be covered only by
+ // ExpansionRegions, and we have to combine their counts in that case.
----------------
Clarify that ExpansionRegions from expanding a macro nested in another macro will have the same source locations. For such a case, the expansion regions's counts need to be combined.
http://reviews.llvm.org/D18831
More information about the llvm-commits
mailing list