[PATCH] D19682: [LSR] Skip transformation if the cost of no LSR is cheaper than the best solution selected

[Quentin Colombet via llvm-commits]

qcolombet added a comment.

Hi Jun,

The thing with LSR is that it is already complex enough that if we can avoid adding more separate paths I think it is best.

> I found the formula from original IR was failed to be added in LSRUse::InsertFormula() because they overlapped with the initial formula created in CollectFixupsAndInitialFormulae().


That is an interesting piece of information!
Why is best better than this one but not better than the one we add with IsNothingCheaperThanBestSolution?

Cheers,
-Quentin


http://reviews.llvm.org/D19682