Re: [PATCH] D17268: [LAA] Function 'isStridedPtr' returns additional result “Loop *Lp” via function argument and add appropriate checks out of the 'isStridedPtr'.

[Adam Nemet via llvm-commits]

anemet added a comment.

In http://reviews.llvm.org/D17268#400137, @roman.shirokiy wrote:

> Also, change of "isStridedPtr" signature made me stumble upon http://reviews.llvm.org/rL263058. With this patch it is unnecessary to pass "Loop* L" through functions affected by http://reviews.llvm.org/rL263058, but there is also suspicious condition "isStridedPtr(PSE, LoadPtr, L) != 1 || isStridedPtr(PSE, LoadPtr, L) != 1", which looks like typo (or relying on side-effects?).


Thanks for noticing.  One of them was supposed to check StorePtr.   Fixed in r268251.


http://reviews.llvm.org/D17268