[PATCH] D19765: [Clang][Builtin][AVX512] Adding intrinsics fot cvt{u}si2s{d|s} cvt{sd|ss}2{ss|sd} instruction set

[Asaf Badouh via llvm-commits]

AsafBadouh added inline comments.

================
Comment at: include/clang/Basic/BuiltinsX86.def:1946
@@ +1945,3 @@
+TARGET_BUILTIN(__builtin_ia32_cvtsd2ss_round_mask, "V4fV4fV4fV2dUcIi","","avx512f")
+TARGET_BUILTIN(__builtin_ia32_cvtsi2sd64, "V2dV2dULLiIi","","avx512f")
+TARGET_BUILTIN(__builtin_ia32_cvtsi2ss32, "V4fV4fiIi","","avx512f")
----------------
ULLi -> LLi (remove the unsigned)

================
Comment at: include/clang/Basic/BuiltinsX86.def:1948
@@ +1947,3 @@
+TARGET_BUILTIN(__builtin_ia32_cvtsi2ss32, "V4fV4fiIi","","avx512f")
+TARGET_BUILTIN(__builtin_ia32_cvtsi2ss64, "V4fV4fULLiIi","","avx512f")
+TARGET_BUILTIN(__builtin_ia32_cvtss2sd_round_mask, "V2dV2dV2dV4fUcIi","","avx512f")
----------------
ULLi -> LLi (remove the unsigned)

================
Comment at: include/clang/Basic/BuiltinsX86.def:1950
@@ +1949,3 @@
+TARGET_BUILTIN(__builtin_ia32_cvtss2sd_round_mask, "V2dV2dV2dV4fUcIi","","avx512f")
+TARGET_BUILTIN(__builtin_ia32_cvtusi2sd32, "V2dV2di","","avx512f")
+TARGET_BUILTIN(__builtin_ia32_cvtusi2sd64, "V2dV2ddIi","","avx512f")
----------------
the second operand is unsigned int, i->Ui

================
Comment at: include/clang/Basic/BuiltinsX86.def:1951
@@ +1950,3 @@
+TARGET_BUILTIN(__builtin_ia32_cvtusi2sd32, "V2dV2di","","avx512f")
+TARGET_BUILTIN(__builtin_ia32_cvtusi2sd64, "V2dV2ddIi","","avx512f")
+TARGET_BUILTIN(__builtin_ia32_cvtusi2ss32, "V4fV4fiIi","","avx512f")
----------------
the second operand of the builtin is ULLi (for unsinged long long)

================
Comment at: include/clang/Basic/BuiltinsX86.def:1952
@@ +1951,3 @@
+TARGET_BUILTIN(__builtin_ia32_cvtusi2sd64, "V2dV2ddIi","","avx512f")
+TARGET_BUILTIN(__builtin_ia32_cvtusi2ss32, "V4fV4fiIi","","avx512f")
+TARGET_BUILTIN(__builtin_ia32_cvtusi2ss64, "V4fV4fdIi","","avx512f")
----------------
the second operand is unsigned int, i->Ui


================
Comment at: include/clang/Basic/BuiltinsX86.def:1953
@@ -1945,1 +1952,3 @@
+TARGET_BUILTIN(__builtin_ia32_cvtusi2ss32, "V4fV4fiIi","","avx512f")
+TARGET_BUILTIN(__builtin_ia32_cvtusi2ss64, "V4fV4fdIi","","avx512f")
 
----------------
same, d-> ULLi



http://reviews.llvm.org/D19765