[lld] r268225 - Don't quote "--hash-style gnu".

Rafael Espindola via llvm-commits llvm-commits at lists.llvm.org
Mon May 2 06:00:43 PDT 2016


Author: rafael
Date: Mon May  2 08:00:42 2016
New Revision: 268225

URL: http://llvm.org/viewvc/llvm-project?rev=268225&view=rev
Log:
Don't quote "--hash-style gnu".

Otherwise lld fails to use the response file.

Modified:
    lld/trunk/ELF/DriverUtils.cpp
    lld/trunk/test/ELF/reproduce.s

Modified: lld/trunk/ELF/DriverUtils.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/DriverUtils.cpp?rev=268225&r1=268224&r2=268225&view=diff
==============================================================================
--- lld/trunk/ELF/DriverUtils.cpp (original)
+++ lld/trunk/ELF/DriverUtils.cpp Mon May  2 08:00:42 2016
@@ -181,7 +181,7 @@ void elf::createResponseFile(const llvm:
          << quote(rewritePath(Arg->getValue())) << "\n";
       break;
     default:
-      OS << quote(Arg->getAsString(Args)) << "\n";
+      OS << Arg->getAsString(Args) << "\n";
     }
   }
 }

Modified: lld/trunk/test/ELF/reproduce.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/reproduce.s?rev=268225&r1=268224&r2=268225&view=diff
==============================================================================
--- lld/trunk/test/ELF/reproduce.s (original)
+++ lld/trunk/test/ELF/reproduce.s Mon May  2 08:00:42 2016
@@ -4,11 +4,12 @@
 # RUN: mkdir -p %t.dir/build1
 # RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.dir/build1/foo.o
 # RUN: cd %t.dir
-# RUN: ld.lld build1/foo.o -o bar -shared --as-needed --reproduce repro
+# RUN: ld.lld --hash-style=gnu build1/foo.o -o bar -shared --as-needed --reproduce repro
 # RUN: diff build1/foo.o repro/%:t.dir/build1/foo.o
 
 # RUN: FileCheck %s --check-prefix=RSP < repro/response.txt
-# RSP:      {{.*}}foo.o
+# RSP: {{^}}--hash-style gnu{{$}}
+# RSP-NEXT: {{.*}}foo.o
 # RSP-NEXT: -o bar
 # RSP-NEXT: -shared
 # RSP-NEXT: --as-needed




More information about the llvm-commits mailing list