[PATCH] D19781: [ASan] Disable target-specific lowering of string functions.

[Marcin Kościelnicki via llvm-commits]

koriakin added a comment.

In http://reviews.llvm.org/D19781#418442, @filcab wrote:

> Thanks for working on this.
>  Can you split this patch in two, please?
>  The SelectionDAG + CodeGen tests on one, the ASan-specific code on another.
>  Not having a proper way to test SelectionDAG is annoying. To have perfecct coverage, we'd need to replicate those tests for other targets. This will do for now, though. :-)


Alright, I'll split it up.  However, there's not much to test for other platforms - only SystemZ currently has customised lowering for those functions.

> BTW, have you measured performance impact?

>  If it's too big, we probably want to put this under a flag (the sanitizer philosophy is that we know we have false negatives, but no false positives, so it fits not doing this by default if it's a big performance hit).


I haven't - I'm still trying to get the testsuite passing on SystemZ.  However, all other platforms are perfectly fine with always running the interceptors, so I doubt there's anything to gain here.


Repository:
  rL LLVM

http://reviews.llvm.org/D19781