[llvm] r268211 - Fix grammar and correct comment - the debug information wasn't incorrect, rather suboptimal.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Sun May 1 22:30:26 PDT 2016


Author: echristo
Date: Mon May  2 00:30:26 2016
New Revision: 268211

URL: http://llvm.org/viewvc/llvm-project?rev=268211&view=rev
Log:
Fix grammar and correct comment - the debug information wasn't incorrect, rather suboptimal.

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp?rev=268211&r1=268210&r2=268211&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp Mon May  2 00:30:26 2016
@@ -971,8 +971,8 @@ SDNode *SelectionDAG::FindNodeOrInsertPo
     case ISD::Constant:
     case ISD::ConstantFP:
       // Erase debug location from the node if the node is used at several
-      // different places to do not propagate one location to all uses as it
-      // leads to incorrect debug info.
+      // different places. Do not propagate one location to all uses as it
+      // will cause a worse single stepping debugging experience.
       if (N->getDebugLoc() != DL)
         N->setDebugLoc(DebugLoc());
       break;




More information about the llvm-commits mailing list