[PATCH] D19752: ELF: New symbol table design.
Peter Collingbourne via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 30 20:16:34 PDT 2016
pcc added a comment.
> Got it. Please add a comment :-)
Done
================
Comment at: ELF/Symbols.h:63-65
@@ +62,5 @@
+ Symbol *symbol();
+ const Symbol *symbol() const {
+ return const_cast<SymbolBody *>(this)->symbol();
+ }
+
----------------
I see. I think all the Symbol objects we ever create are in fact non-const, so this is somewhat of a moot point. Writing these the other way around would I think be a little more verbose, so I'll keep this the way it is. Thanks for pointing that out though.
http://reviews.llvm.org/D19752
More information about the llvm-commits
mailing list