[PATCH] D19752: ELF: New symbol table design.

[Rui Ueyama via llvm-commits]

On Sat, Apr 30, 2016 at 12:34 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> > -  void parse();
> > -
> > -  llvm::MutableArrayRef<LazyObject> getLazySymbols() { return
> LazySymbols; }
> > +  void parse(SymbolTableBase *Symtab);
> >
> > ----------------
> > Can we merge SymbolTableBase with SymbolTable<ELFT> if you template
> this, ArchiveFile::parse and BitcodeFile::parse functions?
>
> I assume these vectors make it hard:
>
>  std::vector<std::unique_ptr<ObjectFile<ELFT>>> ObjectFiles;
>   std::vector<std::unique_ptr<SharedFile<ELFT>>> SharedFiles;
>

I was suggesting defining only SymbolTable<ELFT> and remove
SymbolTableBase.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160430/a36883fc/attachment.html>