[PATCH] D19737: Make --reproduce produce more reproducible logs.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 29 18:40:21 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/DriverUtils.cpp:122
@@ +121,3 @@
+// okay because we don't want to have a complicated logic
+// for a debugging feature.
+static std::string quote(StringRef S) {
----------------
ruiu wrote:
> silvas wrote:
> > Clang generates response files for the linker and has been in production for some time. Can we share that code? I think the code we want to share is part of Command::writeResponseFile.
> I'll try.
Command::writeResponseFile is not reusable for this purpose, and that function is too small to generalize. I think this function is just fine.


http://reviews.llvm.org/D19737





More information about the llvm-commits mailing list