[PATCH] D19737: Make --reproduce produce more reproducible logs.

[Sean Silva via llvm-commits]

silvas added inline comments.

================
Comment at: test/ELF/reproduce.s:20
@@ -16,2 +19,3 @@
 # RUN: ld.lld ./../../../foo.o -o bar -shared --as-needed --reproduce repro
-# RUN: diff %t.dir/build2/foo.o repro/foo.o
+# RUN: diff %t.dir/build2/foo.o repro/%t.dir/build2/foo.o
+
----------------
ruiu wrote:
> silvas wrote:
> > When I tried the first version of your patch this was failing on windows for the same reason as the original reproduce patch did (lit expands a path `foo/C:/...`). Can we avoid the problem?
> Reid suggested defining a new variable "%:t" to get a path without a drive letter. But I'm not sure if it's worth to do. I'm inclined to simply add "REQUIRES: shell" to this file.
As we have seen there are some Windows-specific considerations for --reproduce, so disabling testing for this feature on Windows is unfortunately not an option.


http://reviews.llvm.org/D19737