majnemer added inline comments. ================ Comment at: lib/DebugInfo/PDB/Raw/NameHashTable.cpp:132 @@ +131,3 @@ + } + return 0; // 0 is an invalid name index +} ---------------- If we are going to use `0` as our sentinel, can we assert that `NameIndex` isn't `0`? http://reviews.llvm.org/D19731