[PATCH] D19746: NFC: An iterator for stepping through CodeView type stream in llvm-readobj

Adrian McCarthy via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 29 14:36:18 PDT 2016


amccarth created this revision.
amccarth added a reviewer: rnk.
amccarth added a subscriber: llvm-commits.

This is a small refactoring step toward moving CodeView type stream logic from llvm-readobj to a library.  It abstracts the logic of stepping through the stream into an iterator class and updates llvm-readobj to use that iterator.  This has no functional change; llvm-readobj produces identical output.

The next step is to abstract the parsing of the different leaf types and then move that and the iterator into a library.

Since this is my first contrib outside LLDB, please let me know if I'm messing up on any of the LLVM style guidelines, idioms, or patterns.



http://reviews.llvm.org/D19746

Files:
  tools/llvm-readobj/COFFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19746.55672.patch
Type: text/x-patch
Size: 7779 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160429/12315f78/attachment.bin>


More information about the llvm-commits mailing list