[PATCH] D19737: Make --reproduce produce more reproducible logs.

[Sean Silva via llvm-commits]

silvas requested changes to this revision.
silvas added a reviewer: silvas.
silvas added a comment.
This revision now requires changes to proceed.

I think we can accomplish the goals of this patch without adding a dependence on a shell.


================
Comment at: ELF/DriverUtils.cpp:126
@@ +125,3 @@
+
+// Quote a given string so that it is safe for Unix shell.
+// It replaces ' with '\''.
----------------
It would be better to make invocation.txt be a response file (where we control the quoting) so that we don't depend on having a unix shell. That also avoids needing to hardcode `/ld.lld` which makes things further unportable.


http://reviews.llvm.org/D19737