[PATCH] D18831: [Coverage] Combine counts of expansion region if there are no code regions for the same area.

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 29 11:01:01 PDT 2016


vsk added a comment.

Thanks, this is great!


================
Comment at: unittests/ProfileData/CoverageMappingTest.cpp:455
@@ +454,3 @@
+  startFunction("func", 0x1234);
+  addCMR(Counter::getCounter(0), "include1", 1, 1, 1, 10);
+  addCMR(Counter::getCounter(0), "include2", 1, 1, 1, 10);
----------------
Could you use distinct counters here (e.g {2,3,5,7})? It would help show that the right regions are merged together.


http://reviews.llvm.org/D18831





More information about the llvm-commits mailing list