[PATCH] D19730: [BasicAA] Treat llvm.assume as not accessing memory in getModRefBehavior(Function)

[Geoff Berry via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL268068: [BasicAA] Treat llvm.assume as not accessing memory in getModRefBehavior… (authored by gberry).

Changed prior to commit:
  http://reviews.llvm.org/D19730?vs=55620&id=55621#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D19730

Files:
  llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp
  llvm/trunk/test/Transforms/Util/MemorySSA/assume.ll

Index: llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp
===================================================================
--- llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp
+++ llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp
@@ -575,6 +575,12 @@
   if (F->doesNotAccessMemory())
     return FMRB_DoesNotAccessMemory;
 
+  // While the assume intrinsic is marked as arbitrarily writing so that
+  // proper control dependencies will be maintained, it never aliases any
+  // particular memory location.
+  if (F->getIntrinsicID() == Intrinsic::assume)
+    return FMRB_DoesNotAccessMemory;
+
   FunctionModRefBehavior Min = FMRB_UnknownModRefBehavior;
 
   // If the function declares it only reads memory, go with that.
Index: llvm/trunk/test/Transforms/Util/MemorySSA/assume.ll
===================================================================
--- llvm/trunk/test/Transforms/Util/MemorySSA/assume.ll
+++ llvm/trunk/test/Transforms/Util/MemorySSA/assume.ll
@@ -0,0 +1,17 @@
+; RUN: opt -basicaa -print-memoryssa -verify-memoryssa -analyze < %s 2>&1 | FileCheck %s
+;
+; Ensures that assumes are treated as not reading or writing memory.
+
+declare void @llvm.assume(i1)
+
+define i32 @foo(i32* %a, i32* %b, i1 %c) {
+; CHECK: 1 = MemoryDef(liveOnEntry)
+; CHECK-NEXT: store i32 4
+  store i32 4, i32* %a, align 4
+; CHECK: call void @llvm.assume
+  call void @llvm.assume(i1 %c)
+; CHECK: MemoryUse(1)
+; CHECK-NEXT: %1 = load i32
+  %1 = load i32, i32* %a, align 4
+  ret i32 %1
+}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19730.55621.patch
Type: text/x-patch
Size: 1484 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160429/64f8156c/attachment.bin>