[PATCH] D19688: Fixes PR27241 by enabling the X86 call frame optimization for 64-bit targets

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 29 09:46:10 PDT 2016


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm


================
Comment at: lib/Target/X86/X86CallFrameOptimization.cpp:494-495
@@ +493,4 @@
+        Reg = MRI->createVirtualRegister(&X86::GR64RegClass);
+        BuildMI(MBB, Context.Call, DL, TII->get(X86::IMPLICIT_DEF), UndefReg);
+        BuildMI(MBB, Context.Call, DL, TII->get(X86::INSERT_SUBREG), Reg)
+          .addReg(UndefReg)
----------------
I'm not familiar enough with MI to say if this is the best way to express this, but you have tests for it and that gives me confidence that it works.


http://reviews.llvm.org/D19688





More information about the llvm-commits mailing list