[PATCH] D19611: [CMake] [Darwin] Use libtool instead of ar && ranlib

[Chris Bieneman via llvm-commits]

<rant>
Personally, I think having GNU libtool in your path before the Darwin libtool on Darwin is a bad system configuration, and if we start supporting every random bad system configuration in the build system we’re going to drive ourselves all nuts.
</rant>

That said, since Darwin is pretty uniform we can probably just add “HINTS /usr/bin” after “libtool” on that line and I think it will work for you. Do you want to test that?

If it works, I don’t see any reason not to commit it. Making the build system more robust is generally a good thing, my personal view of maintaining the “purity" of a Darwin system withstanding.

-Chris


> On Apr 29, 2016, at 9:18 AM, Tim Northover <t.p.northover at gmail.com> wrote:
> 
> On 27 April 2016 at 12:15, Chris Bieneman via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> +    find_program(CMAKE_LIBTOOL NAMES libtool)
> 
> I've got GNU libtool in my $PATH (which doesn't support the -static
> option). Would it be reasonable to add a "PATHS /usr/bin" here, or is
> it my own silly fault for doing that?
> 
> Tim.