[PATCH] D18216: [Support] Creation of minidump after compiler crash on Windows

[Leny Kholodov via llvm-commits]

lenykholodov added a comment.

Hi Aaron,

Thank you for review. I have updated patch according to your comments. Could you please take a look?


================
Comment at: include/llvm/Support/Process.h:73
@@ +72,3 @@
+  /// \brief true if PreventCoreFiles has been called, false otherwise.
+  static bool AreCoreFilesPrevented();
+
----------------
Fixed

================
Comment at: lib/Support/Windows/Signals.inc:124
@@ -119,1 +123,3 @@
 
+typedef BOOL(WINAPI *fpMiniDumpWriteDump)(HANDLE, DWORD, HANDLE, MINIDUMP_TYPE,
+                                          PMINIDUMP_EXCEPTION_INFORMATION,
----------------
I have checked llvm support building with mingw and have not found any issues. Could you please clarify what is wrong with this code?

================
Comment at: lib/Support/Windows/Signals.inc:585
@@ +584,3 @@
+static HKEY FindWERKey(const llvm::Twine &RegistryLocation) {
+  HKEY Key;
+  if (ERROR_SUCCESS != ::RegOpenKeyEx(HKEY_LOCAL_MACHINE,
----------------
Fixed

================
Comment at: lib/Support/Windows/Signals.inc:611
@@ +610,3 @@
+
+  SmallVector<wchar_t, MAX_PATH> Buffer(BufferLengthBytes);
+
----------------
This was done similar to using of SmallVector in Path.inc file. I can change type to std::vector. However, this will be inconsistent with other code in Support library.

================
Comment at: lib/Support/Windows/Signals.inc:652
@@ +651,3 @@
+
+  DWORD DumpType;
+  DWORD TypeSize = sizeof(DumpType);
----------------
Fixed

================
Comment at: lib/Support/Windows/Signals.inc:696
@@ +695,3 @@
+  if (MainExecutableName.empty()) {
+    // If we can't get the executable filename,
+    // things are in worse shape than we realize
----------------
Fixed

================
Comment at: lib/Support/Windows/WindowsSupport.h:175
@@ +174,3 @@
+  static handle_type GetInvalid() {
+    return NULL;
+  }
----------------
Fixed


Repository:
  rL LLVM

http://reviews.llvm.org/D18216