[PATCH] D19723: Unify XDEBUG and EXPENSIVE_CHECKS (into the latter), and add an option to the cmake build to enable them.

[Filipe Cabecinhas via llvm-commits]

Heh. I was going for the "be consistent with the code around".
On a second look I noticed consistency is very far away anyway :-P

Will commit soon.

On Fri, Apr 29, 2016 at 4:10 PM, Chandler Carruth via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> chandlerc accepted this revision.
> chandlerc added a comment.
> This revision is now accepted and ready to land.
>
> LGTM, nice!
>
>
> ================
> Comment at: cmake/modules/HandleLLVMOptions.cmake:48-49
> @@ +47,4 @@
> +if( LLVM_ENABLE_EXPENSIVE_CHECKS )
> +  add_definitions( -DEXPENSIVE_CHECKS )
> +  add_definitions( -D_GLIBCXX_DEBUG )
> +endif()
> ----------------
> No need for the spaces inside the ()s here AFAIK... but whatever. =]
>
>
> http://reviews.llvm.org/D19723
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits