[PATCH] D19519: Enable "Optimized Debugging" and Enable "Control Flow Guard" in MSVC builds

[Ben Craig via llvm-commits]

bcraig added a subscriber: bcraig.
bcraig added a comment.

I'm generally in favor of both changes.

For enhanced symbols, I would suggest measuring the size difference in the RelWithDebInfo pdb files before and after this change.  That should tell you if explicitly setting the flag does anything.  It would also be nice to get a build time impact, but that is much less deterministic.

I would prefer that CF Guard be turned on.  If a malicious party sneaks in something on some repo on GitHub, I don't want them to own my machine after compiling it.


http://reviews.llvm.org/D19519