[PATCH] D19663: [ELF] - Basic support of linkerscript commands: DATA_SEGMENT_ALIGN, DATA_SEGMENT_END, CONSTANT

[George Rimar via llvm-commits]

grimar added a comment.

In http://reviews.llvm.org/D19663#415938, @ruiu wrote:

> This comment is not particularly to this patch, but it seems that you are working on the linker script and starting it from easy part. This patch is, for example, easy to implement. We can add small features such as this later after we complete the main part. There is also a chance that we would end up have to refactor the current code so we would have to rewrite everything -- so adding small features first is a bit risky. Therefore, can you focus on design instead of coding? We need a plan with which we are sure we'll be able to implement all the (well, probably not all, but all sane) linker script features.


Ok.
About this little patch: if was fast to do and I assumed that expression evaluation and linker script itself are more or less independent components. And even if we will rewrite everything, such patches introduces new testcases, that are potentially usefull.


http://reviews.llvm.org/D19663