[PATCH] D19627: [scan-build] fix logic error warning emitted on compiler-rt code base

Apelete Seketeli via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 23:33:05 PDT 2016


apelete updated this revision to Diff 55535.
apelete marked an inline comment as done.
apelete added a comment.

[scan-build] fix logic error warning emitted on compiler-rt code base

Changes since last revision:

- Replace assert() with CHECK() since the code do not rely on any system header.


http://reviews.llvm.org/D19627

Files:
  lib/asan/asan_suppressions.cc

Index: lib/asan/asan_suppressions.cc
===================================================================
--- lib/asan/asan_suppressions.cc
+++ lib/asan/asan_suppressions.cc
@@ -89,6 +89,7 @@
 
     if (suppression_ctx->HasSuppressionType(kInterceptorViaFunction)) {
       SymbolizedStack *frames = symbolizer->SymbolizePC(addr);
+      CHECK(frames);
       for (SymbolizedStack *cur = frames; cur; cur = cur->next) {
         const char *function_name = cur->info.function;
         if (!function_name) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19627.55535.patch
Type: text/x-patch
Size: 507 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160429/e5bb6f89/attachment.bin>


More information about the llvm-commits mailing list