[PATCH] D19677: SROA assertion: creating bitcast between ptr types with different addr spaces

[Chandler Carruth via llvm-commits]

chandlerc added a comment.

Note that this patch didn't actually go to the mailing list when you created it, so now the mailing list is missing context on what this patch is even doing. The first email is from Sanjoy.


================
Comment at: test/Transforms/SROA/address-spaces-1.ll:1
@@ +1,2 @@
+; RUN: opt -O3 < %s -S
+
----------------
sanjoy wrote:
> Given that you've filed a PR, it is better to name the test as `prXXXX.ll`.  Also don't use `-O3` here -- you should just invoke the pass you're unit testing (SROA in this case).
> 
> An easy way to do this is to use `-print-before-all` to get the IR right before SROA crashed.
Please don't name the file 'prXXXX.ll' or add a new file at all.

Naming test files after 'pr....' encourages to have more smaller test files when each file adds substantial overhead.

Instead we should be trying to find an existing overarching test file and add the tests to it. Perhaps the 'address-spaces.ll'?


http://reviews.llvm.org/D19677