[PATCH] D17738: [NVPTX] Fix function identifiers that are invalid in PTX and a bug fix for the case of name collisions.

[Rafael Espíndola via llvm-commits]

On Apr 28, 2016 5:39 PM, "Reid Kleckner" <rnk at google.com> wrote:
>
> rnk added a subscriber: rnk.
> rnk added a comment.
>
> In http://reviews.llvm.org/D17738#367459, @rafael wrote:
>
> > The real stable solution I think is for the IR name to be the final
> >  name. No further mangling involved. It will take a lot of work to get
> >  there, but we can avoid making the situation worse.
>
>
> The problem there is that we would have to make the IR symbol renamer not
append '.N' when renaming symbols with name collisions. Until then, we need
something like this.

We only rename internal variables.

> I thought we used to have machinery in our assembler for mangling away
invalid characters. Did you remove that stuff?

Yes, because it was an incredible confusion on what assemblers can handle
and what object files can handle.

If we are asked to create a symbol name that gas cannot handle it is way
better to error than to silently rename it.

Cheers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160428/07bbc930/attachment.html>