[PATCH] D19657: [ASan] Reenable __builtin_setjmp test on PowerPC, disable on SystemZ.

Marcin Koƛcielnicki via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 14:46:42 PDT 2016


koriakin retitled this revision from "[ASan] Change condition for __builtin_longjmp test." to "[ASan] Reenable __builtin_setjmp test on PowerPC, disable on SystemZ.".
koriakin updated the summary for this revision.
koriakin updated this revision to Diff 55494.
koriakin added a comment.

Since the test can actually work on multiple platforms (all of them presumably, given support from backend), let's keep the blacklist.  However, disable it for the upcoming SystemZ port, which  currently doesn't support the builtin, and reenable it for PowerPC, whose builtin has just been fixed.


Repository:
  rL LLVM

http://reviews.llvm.org/D19657

Files:
  lib/asan/tests/asan_test.cc

Index: lib/asan/tests/asan_test.cc
===================================================================
--- lib/asan/tests/asan_test.cc
+++ lib/asan/tests/asan_test.cc
@@ -595,9 +595,8 @@
 }
 
 #if !defined(__ANDROID__) && !defined(__arm__) && \
-    !defined(__powerpc64__) && !defined(__powerpc__) && \
-    !defined(__aarch64__) && !defined(__mips__) && \
-    !defined(__mips64)
+    !defined(__aarch64__) && !SANITIZER_MIPS && \
+    !SANITIZER_S390
 NOINLINE void BuiltinLongJmpFunc1(jmp_buf buf) {
   // create three red zones for these two stack objects.
   int a;
@@ -619,9 +618,9 @@
     TouchStackFunc();
   }
 }
-#endif  // !defined(__ANDROID__) && !defined(__powerpc64__) &&
-        // !defined(__powerpc__) && !defined(__arm__) &&
-        // !defined(__mips__) && !defined(__mips64)
+#endif  // !defined(__ANDROID__) && !defined(__arm__) &&
+        // !defined(__aarch64__) && !SANITIZER_MIPS
+        // !SANITIZER_S390
 
 TEST(AddressSanitizer, UnderscopeLongJmpTest) {
   static jmp_buf buf;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19657.55494.patch
Type: text/x-patch
Size: 1011 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160428/2d616d0b/attachment.bin>


More information about the llvm-commits mailing list