[PATCH] D18841: [InstCombine] Canonicalize icmp instructions based on dominating conditions.

[David Majnemer via llvm-commits]

majnemer added a comment.

Generally speaking, InstCombine canonicalization helps out down stream analysis by simplifying the IR or exposes further opportunities for canonicalization.  i'm not entirely sure that this transform fits that bill.

I wonder if a more appropriate place for this to live is in CodeGenPrepare seeing as how sensitive this transform is to the peculiarities of the target ISA, perhaps with a TargetLowering check which verifies that it would make sense to perform on such a target.


http://reviews.llvm.org/D18841