[PATCH] D19438: Reset the TopRPTracker's position in ScheduleDAGMILive::initQueues

[Matthias Braun via llvm-commits]

MatzeB added a comment.

You should be able to access the "protected:" TopRPTracker field in subclasses directly. Regardless this change should be fine.

Is the test minimal yet? It appears to be a lot bigger than necessary (all the metadata debug info seems superfluous for example).


================
Comment at: include/llvm/CodeGen/MachineScheduler.h:467-471
@@ +466,7 @@
+  void initQueues(ArrayRef<SUnit*> TopRoots, ArrayRef<SUnit*> BotRoots) {
+    ScheduleDAGMI::initQueues(TopRoots, BotRoots);
+    if (ShouldTrackPressure) {
+      assert(TopRPTracker.getPos() == RegionBegin && "bad initial Top tracker");
+      TopRPTracker.setPos(CurrentTop);
+    }
+  }
----------------
This is not performancce critical so the implementation can stay in the .cpp file.


Repository:
  rL LLVM

http://reviews.llvm.org/D19438