[PATCH] D19646: DivergenceAnalysis: Fix crash with unreachable blocks

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 10:25:42 PDT 2016


arsenm added inline comments.

================
Comment at: lib/Analysis/DivergenceAnalysis.cpp:189
@@ +188,3 @@
+    DomTreeNode *InfluenceNode = DT.getNode(InfluencedBB);
+    if (!InfluenceNode)
+      break;
----------------
jingyue wrote:
> This seems unnecessary. ThisBB is guaranteed reachable according to the check you added above. InfluenceBB is guaranteed to dominate ThisBB, so it must be reachable too. 
> 
> If you agree, maybe change this if to an assert. 
I hit the first one, and then hit another crash here


http://reviews.llvm.org/D19646





More information about the llvm-commits mailing list