[llvm] r267815 - [PGO] Promote indirect calls to conditional direct calls with value-profile

[Rong Xu via llvm-commits]

I guess the mismatches are:

remark: <unknown>:0:0: : The number of arguments mismatch
and I expected:
emark: <unknown>:0:0: Cannot promote indirect call to func4 with count of
1234: The number of arguments mismatch

For the indrect-call-promotion.ll:

remark: <unknown>:0:0: 1600
while I was expecting:
remark: <unknown>:0:0: Promote indirect call to func4 with count 1030 out
of 1600
               ^
It's strange that Twine messages became incomplete -- only the last
component got output.



On Thu, Apr 28, 2016 at 8:53 AM, Xinliang David Li <xinliangli at gmail.com>
wrote:

> what I meant is the output that gets piped to FileCheck, not the FileCheck
> output.
>
> thanks,
>
> David
>
> On Thu, Apr 28, 2016 at 8:48 AM, Ismail Donmez <ismail at i10z.com> wrote:
>
>> That's all of the output (excluding the command line part).
>>
>> On Thu, Apr 28, 2016 at 6:46 PM, Xinliang David Li <xinliangli at gmail.com>
>> wrote:
>> > What does the actual output look like?
>> >
>> > David
>> >
>> > On Thu, Apr 28, 2016 at 1:57 AM, Ismail Donmez via llvm-commits
>> > <llvm-commits at lists.llvm.org> wrote:
>> >>
>> >> Hi,
>> >>
>> >> On Thu, Apr 28, 2016 at 2:20 AM, Rong Xu via llvm-commits
>> >> <llvm-commits at lists.llvm.org> wrote:
>> >> > Author: xur
>> >> > Date: Wed Apr 27 18:20:27 2016
>> >> > New Revision: 267815
>> >> >
>> >> > URL: http://llvm.org/viewvc/llvm-project?rev=267815&view=rev
>> >> > Log:
>> >> > [PGO] Promote indirect calls to conditional direct calls with
>> >> > value-profile
>> >> >
>> >> > This patch implements the transformation that promotes indirect
>> calls to
>> >> > conditional direct calls when the indirect-call value profile
>> meta-data
>> >> > is
>> >> > available.
>> >> >
>> >> > Differential Revision: http://reviews.llvm.org/D17864
>> >> >
>> >> > Added:
>> >> >
>>  llvm/trunk/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
>> >> >
>>  llvm/trunk/test/Transforms/PGOProfile/icp_covariant_call_return.ll
>> >> >
>>  llvm/trunk/test/Transforms/PGOProfile/icp_covariant_invoke_return.ll
>> >> >     llvm/trunk/test/Transforms/PGOProfile/icp_invoke.ll
>> >> >     llvm/trunk/test/Transforms/PGOProfile/icp_mismatch_msg.ll
>> >> >     llvm/trunk/test/Transforms/PGOProfile/icp_vararg.ll
>> >> >     llvm/trunk/test/Transforms/PGOProfile/indirect_call_promotion.ll
>> >> > Modified:
>> >> >     llvm/trunk/include/llvm/InitializePasses.h
>> >> >     llvm/trunk/include/llvm/LinkAllPasses.h
>> >> >     llvm/trunk/include/llvm/Transforms/Instrumentation.h
>> >> >     llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp
>> >> >     llvm/trunk/lib/Transforms/Instrumentation/CMakeLists.txt
>> >> >     llvm/trunk/lib/Transforms/Instrumentation/Instrumentation.cpp
>> >>
>> >> Fails with VS2015 x64:
>> >>
>> >>
>> >>
>> C:\cygwin64\home\ismail\src\llvm\test\Transforms\PGOProfile\icp_mismatch_msg.ll:3:10:
>> >> error: expected string not found in input
>> >> ; CHECK: remark: <unknown>:0:0: Cannot promote indirect call to func4
>> >> with count of 1234: The number of arguments mismatch
>> >>          ^
>> >> <stdin>:1:1: note: scanning from here
>> >> remark: <unknown>:0:0: : The number of arguments mismatch
>> >> ^
>> >>
>> >>
>> >>
>> C:\cygwin64\home\ismail\src\llvm\test\Transforms\PGOProfile\indirect_call_promotion.ll:3:16:
>> >> error: expected string not found in input
>> >> ; PASS-REMARK: remark: <unknown>:0:0: Promote indirect call to func4
>> >> with count 1030 out of 1600
>> >>                ^
>> >> <stdin>:1:1: note: scanning from here
>> >> remark: <unknown>:0:0: 1600
>> >> ^
>> >> _______________________________________________
>> >> llvm-commits mailing list
>> >> llvm-commits at lists.llvm.org
>> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>> >
>> >
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160428/15268f15/attachment.html>