[PATCH] D19426: [AArch64] Use the reciprocal estimation machinery

Evandro Menezes via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 08:20:33 PDT 2016


On 04/28/16 01:17, James Molloy wrote:
> Hi Evandro,
>
>> On 27 Apr 2016, at 21:34, Evandro Menezes <e.menezes at samsung.com 
>> <mailto:e.menezes at samsung.com>> wrote:
>>
>> Hopefully the context of this hook may allow querying the sub-target 
>> about such details.  I'll start working on this soon. Still, methinks 
>> that this patch is good for some sub-targets as is and it shouldn't 
>> be the enemy of "perfection". ;-)
>
> Sure, I’m all for incremental development. A target hook that says 
> “return IsExynosM1;” is good enough at this stage for me. What I’m 
> saying is I’d like this to be controlled by a target hook, not by a 
> subtarget feature, as the heuristic of whether to enable it or not 
> will *eventually* be more complex than just “always for this chip and 
> never for this other chip”.
>
> I hope this makes sense.

Got it!

Thank you,

-- 
Evandro Menezes




More information about the llvm-commits mailing list