[PATCH] D19657: [ASan] Change condition for __builtin_longjmp test.

Marcin Koƛcielnicki via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 06:56:55 PDT 2016


koriakin created this revision.
koriakin added reviewers: kcc, eugenis.
koriakin added a subscriber: llvm-commits.
koriakin set the repository for this revision to rL LLVM.
koriakin added a project: Sanitizers.
Herald added subscribers: kubabrecka, srhines, danalbert, tberghammer.

Since the only target that actually supports __builtin_longjmp is x86,
and it's unlikely to change, whitelist x86 instead of blacklisting
all other architectures.

Repository:
  rL LLVM

http://reviews.llvm.org/D19657

Files:
  lib/asan/tests/asan_test.cc

Index: lib/asan/tests/asan_test.cc
===================================================================
--- lib/asan/tests/asan_test.cc
+++ lib/asan/tests/asan_test.cc
@@ -594,10 +594,7 @@
   siglongjmp(buf, 1);
 }
 
-#if !defined(__ANDROID__) && !defined(__arm__) && \
-    !defined(__powerpc64__) && !defined(__powerpc__) && \
-    !defined(__aarch64__) && !defined(__mips__) && \
-    !defined(__mips64)
+#if !defined(__ANDROID__) && (defined(__i386__) || defined(__x86_64__))
 NOINLINE void BuiltinLongJmpFunc1(jmp_buf buf) {
   // create three red zones for these two stack objects.
   int a;
@@ -619,9 +616,7 @@
     TouchStackFunc();
   }
 }
-#endif  // !defined(__ANDROID__) && !defined(__powerpc64__) &&
-        // !defined(__powerpc__) && !defined(__arm__) &&
-        // !defined(__mips__) && !defined(__mips64)
+#endif  // !defined(__ANDROID__) && (defined(__i386__) || defined(__x86_64__))
 
 TEST(AddressSanitizer, UnderscopeLongJmpTest) {
   static jmp_buf buf;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19657.55409.patch
Type: text/x-patch
Size: 977 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160428/35f1b24c/attachment.bin>


More information about the llvm-commits mailing list