[PATCH] D19181: Map Attribute in the C API.

Jakob Bornecrantz via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 02:38:55 PDT 2016


Wallbraker added a comment.

I kind of prefer the AttributeSet approach, but don't feel to strongly about it.

Creating immutable state objects up front and then reusing it will always be faster then individually setting state on objects. Also AttributeSets better reflect what you see when you read the LLVM bitcode textual representation.

Should AttributeSet go away we can keep a copy around in the C interface.


http://reviews.llvm.org/D19181





More information about the llvm-commits mailing list