[PATCH] D19641: Add an alternative to LLVMMDNode that will only accept metadata as argument.

[Jakob Bornecrantz via llvm-commits]

Wallbraker requested changes to this revision.
Wallbraker added a comment.
This revision now requires changes to proceed.

I strongly feel that we should just add new function and then remove the old ones the release after.

You are changing API, we do that in LLVM by adding new functions, then removing the old ones. The fact that the type sizes line up is just a happy coincidence. Doing it your way adds more risks its not certain that you have covered all of the use cases, adding duplicated functions makes sure we get all of them because we are actually using the type system to work for us. And adding new functions also lets us get a clear view of what the new API will look like.

And its not like we are going to have 13 more functions forever, its just for a release.


http://reviews.llvm.org/D19641