[PATCH] D19585: [libFuzzer] Improve documentation

[David Drysdale via llvm-commits]

daviddrysdale added a comment.

In http://reviews.llvm.org/D19585#413936, @kcc wrote:

> This is very cool, thanks! 
>  I've made several minor comments. 
>  The patch does not apply to ToT (arc patch http://reviews.llvm.org/D19585 says 2 out of 14 hunks FAILED), for some reason, you may need to svn up / merge.


Sorry, forgot to merge up first.  BTW, does Phabricator show whether the patch applies cleanly somewhere?  I can't immediately see it in the UI.


================
Comment at: docs/LibFuzzer.rst:2
@@ +1,3 @@
+=======================================================
+libFuzzer – a library for coverage-guided fuzz testing.
+=======================================================
----------------
OK, but how do you want to handle sentences that start with the name -- capitalize or not?

(At the moment I've left sentence starts as "LibFuzzer does xyz...")

================
Comment at: docs/LibFuzzer.rst:377-380
@@ -161,5 +376,6 @@
   # Get PCRE2
-  svn co svn://vcs.exim.org/pcre2/code/trunk pcre
-  # Build PCRE2 with AddressSanitizer and coverage.
-  (cd pcre; ./autogen.sh; CC="clang -fsanitize=address $COV_FLAGS" ./configure --prefix=`pwd`/../inst && make -j && make install)
+  wget ftp://ftp.csx.cam.ac.uk/pub/software/programming/pcre/pcre2-10.20.tar.gz
+  tar xf pcre2-10.20.tar.gz
+  # Build PCRE2 with AddressSanitizer and coverage; requires autotools.
+  (cd pcre2-10.20; ./autogen.sh; CC="clang -fsanitize=address $COV_FLAGS" ./configure --prefix=`pwd`/../inst && make -j && make install)
   # Build the fuzzing target function that does something interesting with PCRE2.
----------------
When I tried it, the current SVN tip wouldn't build, so I thought it safer to stick with a fixed release -- less vulnerable that way.


http://reviews.llvm.org/D19585