[PATCH] D19634: Read the rest of the substreams from DBI, and parse source file information
Zachary Turner via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 27 21:54:29 PDT 2016
zturner added inline comments.
================
Comment at: lib/DebugInfo/PDB/Raw/PDBDbiStream.cpp:216-218
@@ +215,5 @@
+ //
+ const uint8_t *Buf = &FileInfoSubstream[0];
+ auto FI = reinterpret_cast<const FileInfoSubstreamHeader *>(Buf);
+ Buf += sizeof(FileInfoSubstreamHeader);
+ // The number of modules in the stream should be the same as reported by
----------------
majnemer wrote:
> Couldn't you also do:
> auto *Buf = reinterpret_cast<const ulittle16_t *>(&FileInfoSubstream[1]);
Did you mean
```
auto *Buf = reinterpret_cast<const ulittle16_t*>(FI + 1);
```
?
http://reviews.llvm.org/D19634
More information about the llvm-commits
mailing list