[PATCH] D19522: Read discriminators correctly from object file.

[Dehao Chen via llvm-commits]

Sorry that I didn't add more context about the update.

Originally in this patch, I only reset discriminator when there is
line change. But turns out the correct behavior is to update the
discriminator whenever a special opcode has been encountered, no
matter there is line change or not. This means that the implementation
in the original patch is incorrect, that's why I updated the patch and
added a new testcase to cover this situation.

Thanks,
Dehao

On Wed, Apr 27, 2016 at 6:48 PM, David Blaikie <dblaikie at gmail.com> wrote:
>
>
> On Wed, Apr 27, 2016 at 6:28 PM, Dehao Chen via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> danielcdh updated this revision to Diff 55367.
>> danielcdh added a comment.
>>
>> Fixed another bug in the implemantation to make it consistent with gnu
>> assembler.
>
>
> Sounds like it should be a separate patch/independent change?
>
>>
>>
>> PTAL, Thanks
>>
>>
>> http://reviews.llvm.org/D19522
>>
>> Files:
>>   lib/DebugInfo/DWARF/DWARFDebugLine.cpp
>>   lib/MC/MCDwarf.cpp
>>   test/DebugInfo/X86/discriminator2.ll
>>   test/DebugInfo/X86/discriminator3.ll
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>