[PATCH] D19634: Read the rest of the substreams from DBI, and parse source file information

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: include/llvm/DebugInfo/PDB/Raw/PDBDbiStream.h:47
@@ -45,3 +46,3 @@
 
-  llvm::iterator_range<ModInfoIterator> modules() const;
+  llvm::iterator_range<ModuleInfoList::const_iterator> modules() const;
 
----------------
Why don't you return ArrayRef<ModuleInfoEx>?

================
Comment at: lib/DebugInfo/PDB/Raw/PDBDbiStream.cpp:183-186
@@ -152,4 +182,6 @@
 
-llvm::iterator_range<ModInfoIterator> PDBDbiStream::modules() const {
-  return llvm::make_range(ModInfoIterator(&ModInfoSubstream.front()),
-                          ModInfoIterator(&ModInfoSubstream.back() + 1));
+llvm::iterator_range<PDBDbiStream::ModuleInfoList::const_iterator>
+PDBDbiStream::modules() const {
+  return llvm::make_range(ModuleInfos.begin(), ModuleInfos.end());
+}
+
----------------
This can return ArrayRef<ModuleInfoEx>?


http://reviews.llvm.org/D19634